Only set the externalTrafficPolicy when spec.type is not ClusterIP #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebSpider
changed the title
|
Trivy seems to be setup incorrectly |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
baby-gnu
approved these changes
Dec 2, 2024
github-actions
bot
removed
the
Stale
|
When can we expect this to be merged? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
/unstale |
github-actions
bot
removed
the
Stale
There was a problem hiding this comment.
Pull Request Overview
This PR prevents setting the externalTrafficPolicy field when the Kubernetes service type is ClusterIP, which is not supported according to Kubernetes issue #67202.
- Added a conditional check to only set
externalTrafficPolicywhen service type is notClusterIP
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
promasu
suggested changes
Oct 17, 2025
Co-authored-by: Adrian Nöthlich <[email protected]>
DrPsychick
approved these changes
Oct 17, 2025
|
@WebSpider can you please rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
externalTrafficPolicyto anything non-default is not supported onClusterIPas per kubernetes/kubernetes#67202Fixes #266